Allow override of URL to download SFDX CLI tarball#9
Open
daveespo wants to merge 6 commits intosfdx-actions:masterfrom
Open
Allow override of URL to download SFDX CLI tarball#9daveespo wants to merge 6 commits intosfdx-actions:masterfrom
daveespo wants to merge 6 commits intosfdx-actions:masterfrom
Conversation
…tps://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#adding-a-system-path now that there's no longer an install script for sfdx
…ecifying an alternative tarball to install for the CLI; useful for when 'latest' is hopelessly broken
PMGR-9933 - allow overriding of the URL that contains the SFDX CLI so that if a regression is introduced into the CLI, we can easily roll back to an older version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have gotten burned a few times by always running the 'latest' SFDX CLI in our CI workflow. The most recent example of this was over here:
forcedotcom/cli#1165
This pull request adds a new input for the Action so that the URL to the tarball can be overridden in the workflow file to pin your workflow to a stable version of the CLI
This PR builds upon my other PR that still is awaiting merge (#8)